Broken Things

[Galahad]

Given the recent migration (Thanks Tig ) some stuff may be broken. I found something. First!

This post:
viewtopic.php?p=1537883#p1537883

If you click on the photo of the E28 with the hood open, it redirects to a page not found with a horrible looking URL with an embedded Imgur link. I don't know what intended behavior is, but I suspect it's not that.

[4DSC]

Might be a me only thing, but when I'm on mobile (android Pixel) the new picture as the top is slightly wider/misaligned with the rest of the content below it which results in an ever so slight left/right scrolling effect when you browse up/down naturally, which can be "fixed" by zooming out, but has to be done manually on every post view.

[tig]

Given the recent migration (Thanks Tig ) some stuff may be broken. I found something. First!

This post:
viewtopic.php?p=1537883#p1537883

If you click on the photo of the E28 with the hood open, it redirects to a page not found with a horrible looking URL with an embedded Imgur link. I don't know what intended behavior is, but I suspect it's not that.

There are multiple photos with E28s with hood open on that page. When I click on them I get the standard phpBB 404 page a the URL of:

Code: Select all

https://www.mye28.com/%5Bimg%5Dhttps%3A//i.imgur.com/eGlPVbI.jpeg%5B/img%5D

... which makes sense given the bbcodes are:

Code: Select all

[url][img]https://i.imgur.com/ooR5Toh.jpeg[/img][/url]

[url][img]https://i.imgur.com/4m7EEfj.jpeg[/img][/url]

[url][img]https://i.imgur.com/eAsG7js.jpeg[/img][/url]

[url][img]https://i.imgur.com/hWHrfbI.jpeg[/img][/url]

[url][img]https://i.imgur.com/eGlPVbI.jpeg[/img][/url]

[url][img]https://i.imgur.com/qYRPmve.jpeg[/img][/url]

[url][img]https://i.imgur.com/QWUSZNu.jpeg[/img][/url]

IOW, there's no URL given in the url tags.

[tig]

Might be a me only thing, but when I'm on mobile (android Pixel) the new picture as the top is slightly wider/misaligned with the rest of the content below it which results in an ever so slight left/right scrolling effect when you browse up/down naturally, which can be "fixed" by zooming out, but has to be done manually on every post view.

Not just a you thing.

I will fix this asap.

[tig]

Might be a me only thing, but when I'm on mobile (android Pixel) the new picture as the top is slightly wider/misaligned with the rest of the content below it which results in an ever so slight left/right scrolling effect when you browse up/down naturally, which can be "fixed" by zooming out, but has to be done manually on every post view.

Not just a you thing.

I will fix this asap.

This should be fixed now. Please let me know if you think it's not. Clear browsing data in your browser for mye28.com first.

[4DSC]

Fixed here now as well! Excellent work, thanks!

[Galahad]

Given the recent migration (Thanks Tig ) some stuff may be broken. I found something. First!

This post:
viewtopic.php?p=1537883#p1537883

If you click on the photo of the E28 with the hood open, it redirects to a page not found with a horrible looking URL with an embedded Imgur link. I don't know what intended behavior is, but I suspect it's not that.

There are multiple photos with E28s with hood open on that page. When I click on them I get the standard phpBB 404 page a the URL of:

Code: Select all

https://www.mye28.com/%5Bimg%5Dhttps%3A//i.imgur.com/eGlPVbI.jpeg%5B/img%5D

... which makes sense given the bbcodes are:

Code: Select all

[img]https://i.imgur.com/ooR5Toh.jpeg[/img]

[img]https://i.imgur.com/4m7EEfj.jpeg[/img]

[img]https://i.imgur.com/eAsG7js.jpeg[/img]

[img]https://i.imgur.com/hWHrfbI.jpeg[/img]

[img]https://i.imgur.com/eGlPVbI.jpeg[/img]

[img]https://i.imgur.com/qYRPmve.jpeg[/img]

[img]https://i.imgur.com/QWUSZNu.jpeg[/img]

IOW, there's no URL given in the url tags.

 

 

Apologies for the lack of specificity, I was trying to look at the 5th photo in the post from the 31st (seeing if this guy has a fuse board or not), but they all have the same behavior.

Before the migration, clicking on an image formatted as we're discussing would redirect to the Imgur page where you could zoom in to your heart's content.

Also, the WYSIWYG editor loaded the photos full size in the quote instead of rendering as a code block, likely this is an unintended edge case. The preview function (and fingers crossed the actual post) have a code block as intended.

[tig]

Here's how it works. I've tested this on phpbb.com to ensure I'm not cray...

An img tag on it's own, has no behavior. Clicking on it does nothing:

Code: Select all

[img]https://i.imgur.com/PzDxBKe.png[/img]

The resultant HTML is:

Code: Select all

<img src="https://i.imgur.com/PzDxBKe.png" class="postimage" alt="Image">

An img tag surrounded by a url tag, where there is no specified url tries to go to the text within the url tag. This will NEVER work:

Code: Select all

[url][img]https://i.imgur.com/PzDxBKe.png[/img][/url]

The resultant HTML is below. The <a> has an href to the encoded text that is within the url tag, and it behaves exactly as one would expect (badly):

Code: Select all

<a href="%5Bimg%5Dhttps%3A//i.imgur.com/PzDxBKe.png%5B/img%5D" class="postlink"><img src="https://i.imgur.com/PzDxBKe.png" class="postimage" alt="Image"></a>

What you've seen work before is below. Where the url tag is used properly, by specifying the target with url=. Almost all of my posts, where I use Flickr, have this done correctly:

Code: Select all

[url=https://i.imgur.com/PzDxBKe.png][img]https://i.imgur.com/PzDxBKe.png[/img][/url]

The resultant HTML is:

Code: Select all

<a href="https://i.imgur.com/PzDxBKe.png" class="postlink"><img src="https://i.imgur.com/PzDxBKe.png" class="postimage" alt="Image"></a>